Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused fields #984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused fields #984

wants to merge 1 commit into from

Conversation

ovbm
Copy link
Contributor

@ovbm ovbm commented Dec 20, 2024

Removes twitterHandle, facebookId and publicUrl from front- and backend.

ToDo:

  • Test migration and deployment on staging

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
staging-republik-love ✅ Ready (Inspect) Visit Preview Dec 20, 2024 3:26pm

Comment on lines +2 to +4
DROP COLUMN "twitterHandle";
DROP COLUMN "facebookId";
DROP COLUMN "publicUrl";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, DROP statements need to be separated by commas

Comment on lines +2 to +4
ADD COLUMN "publicUrl" text;
ADD COLUMN "facebookId" text;
ADD COLUMN "publicUrl" text;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL syntax here is wrong. ; ends a statement so the ADD COLUMN after publicUrl will fail.

The lines should be delimited by ,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants