Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Project and Package references of Reqnroll.Verify are inconsistent #447

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

gasparnagy
Copy link
Contributor

@gasparnagy gasparnagy commented Feb 11, 2025

🤔 What's changed?

Changed the package dependency and description of the Reqnroll.Verify plugin to be in sync with the real dependency.
Also migrated Reqnroll.Verify.ReqnrollPlugin.IntegrationTest to Reqnroll.SystemTests/Plugins/VerifyPluginTest.cs

⚡️ What's your motivation?

Fixes #446 and reqnroll/Reqnroll.VisualStudio#69

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

n/a

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@ajeckmans ajeckmans self-requested a review February 11, 2025 13:39
Copy link
Contributor

@ajeckmans ajeckmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change :) I don't know why I did not notice this when I updated the plugin the last time.

@gasparnagy gasparnagy merged commit 5df58dc into main Feb 11, 2025
5 checks passed
@gasparnagy gasparnagy deleted the fix-verify-dep-inconsistency-issue-446 branch February 11, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project and Package references of Reqnroll.Verify are inconsistent
2 participants