-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with using Nextcloud OAuth trough Generic OAuth connector (ID Token not present in token response) #2392
Comments
I have the same problem when trying to use Gitea as oAuth provider. Same config works fine for other applications using it as oAuth provider. |
Same problems here with our own home-grown OIDC auth endpoint. I can see wiki.js making a POST to our token endpoint, which responds something like this:
But it doesn't get as far as making a request to our userinfo endpoint. |
I'm getting the same results. OS: Docker My homegrown endpoint appears to be working fine, as I'm able to obtain the proper tokens by using a third-party tool like Postman, but Wiki.js fails with the error described above. I can't think of any alternative to make this work. |
I am also affected by this issue. OS: Ubuntu Server 20.04.1 LTS I tried it with Nextcloud and with a Forum based on Woltlab Burning Board with an Addon called "Oauth 2.0 Server". |
I have the same problem. I think wiki.js implements the OAuth 'implicit flow' to get the access token: the auth server returns the token immediately. |
That's an interesting idea, I wasn't aware of the difference. Checking through the documentation of my PHP OAuth library (league/oauth2-server), the implicit workflow would have the client send a I don't pretend to be super familiar with OAuth, so if someone else could chime in on this, it would be nice! |
After having another look, I realize that I was mistaken. The error message reads "ID token not present in token response". But when I inspect the browser requests in the developer console, I see that the redirect from the So something seems to be wired incorrectly. |
Same issue with oauth2 login. Looks like wiki.js support only OpenID type of OAuth2 protocol. =( |
Same for me here with trying to connect to Mattermost as OAuth provider. |
This PR shoul fix requarks#2392. Used `passport-oauth2` strategy.
Just run into the same problem, the callback to https://wikijsthing/login/71ece951-xxx/callback?state=something&code=somestuff crashes with 500 server error. I do not see any token call, I guess this should be done under the hood. |
* OAuth2 authentication implementation This PR shoul fix #2392. Used `passport-oauth2` strategy. * indentations cleanup * cleanup code
* OAuth2 authentication implementation This PR shoul fix requarks#2392. Used `passport-oauth2` strategy. * indentations cleanup * cleanup code
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Question
I'm struggling to make wikijs working with Nextcloud as OAuth provider via Generic OpenID/OAuth connector. After successful redirection to Nextcloud login page and granting access Wikijs throws me an "ID Token not present in token response" error. In wikijs logs there is no error, nginx and nextcloud logs show, that token was received, but user data wasn't requested. Other services with Nextcloud as OAuth provider (Jupyterhub, Vouch proxy and so on) working okay. Is it a bug or I'm doing something wrong?
Host Info (please complete the following information):
OS: Docker
Wiki.js version: 2.5.126
Database engine: Postgres 11
The text was updated successfully, but these errors were encountered: