Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TOC scrollable if higher than the viewport #1829

Merged
merged 2 commits into from
May 22, 2020
Merged

Conversation

Pwuts
Copy link
Contributor

@Pwuts Pwuts commented May 4, 2020

Erratum on #1825

Problem:
If the sticky table of contents is higher than the viewport, the overflowing part can only be accessed by scrolling to the bottom of the page.

Solution:
Make the table of contents itself scrollable and limit its height to that of the viewport.

@auto-assign auto-assign bot requested a review from NGPixel May 4, 2020 13:07
@Pwuts
Copy link
Contributor Author

Pwuts commented May 4, 2020

image
Screenshot shows a version with scrollbar, but imo the scrollbar was too prominent that way so I left it out in the PR.

Scrollbar additional code:

.page-col-sd {
  &::-webkit-scrollbar {
  /*   display: none; */
    width: 0.2em;
  }

  &::-webkit-scrollbar-track {
    margin: 12px;
    background-color: #e0e0e0;
  }

  &::-webkit-scrollbar-thumb {
    background-color: #1976d2;
  }
}

@Pwuts
Copy link
Contributor Author

Pwuts commented May 9, 2020

resolved conflict

@Pwuts
Copy link
Contributor Author

Pwuts commented May 11, 2020

@NGPixel I would advise processing this PR before the next release, as it should have been included in #1825 which has already been merged

@NGPixel NGPixel merged commit d44c9a0 into requarks:master May 22, 2020
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants