fix: tokenRenewal seems to be hard coded #1540 #2042
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regevbr
changed the title
|
@NGPixel can you please CR? Super short fix... |
1 similar comment
|
@NGPixel can you please CR? Super short fix... |
NGPixel
reviewed
Jun 18, 2020
server/core/auth.js
Outdated
| @@ -112,7 +113,8 @@ module.exports = { | |||
| if (err) { return next() } | |||
|
|
|||
| // Expired but still valid within N days, just renew | |||
| if (info instanceof Error && info.name === 'TokenExpiredError' && moment().subtract(14, 'days').isBefore(info.expiredAt)) { | |||
| if (info instanceof Error && info.name === 'TokenExpiredError' && | |||
| moment.subtract(ms(WIKI.config.auth.tokenRenewal), 'ms').isBefore(info.expiredAt)) { | |||
There was a problem hiding this comment.
Should be moment(), otherwise you're relying on an existing instance which could have been modified previously.
There was a problem hiding this comment.
@NGPixel fixed, please review
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
* fix: tokenRenewal seems to be hard coded requarks#1540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1540