Skip to content

Add overflow scroll to search results #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2020
Merged

Add overflow scroll to search results #2232

merged 2 commits into from
Aug 15, 2020
+1 −0

Conversation

puppycodes
Copy link
Contributor

All search results were not visible on desktop screens beyond the viewport height, adding overflow-y: scroll fixes this

ezgif-1-671563cb08f8

@puppycodes
Add overflow scroll to search results

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
445caa8 
All search results were not visible on desktop screens beyond the viewport height, adding overflow-y: scroll fixes this
@auto-assign auto-assign bot requested a review from NGPixel July 27, 2020 05:50
@Jhobean
Copy link

Jhobean commented Jul 27, 2020 •
edited
Loading

Think is a fix of this issues #1672

@Jhobean Jhobean mentioned this pull request Aug 9, 2020
Closed
@Smankusors Smankusors mentioned this pull request Aug 9, 2020
Closed
@NGPixel
Copy link
Member

NGPixel commented Aug 10, 2020

Should be auto, not scroll as otherwise it will always display a scrollbar on larger screen (on non-Mac machines at least).

@puppycodes
Update search-results.vue

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f274ee6
@puppycodes
Copy link
Contributor Author

Should be auto, not scroll as otherwise it will always display a scrollbar on larger screen (on non-Mac machines at least).

updated ;)

@NGPixel NGPixel merged commit b588e55 into requarks:dev Aug 15, 2020
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
@puppycodes
fix: add overflow scroll to search results (requarks#2232)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
532856b 
* Add overflow scroll to search results

All search results were not visible on desktop screens beyond the viewport height, adding overflow-y: scroll fixes this

* Update search-results.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel

Assignees

@NGPixel NGPixel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puppycodes @Jhobean @NGPixel