Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add baecon and error baecon newrelic parameters for eu region support #4421

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

goto1134
Copy link
Contributor

@goto1134 goto1134 commented Sep 13, 2021

EU newrelic baecon and error baecon are different from US locale:

{ 
  "beacon": "bam.eu01.nr-data.net",
  "errorBeacon": "bam.eu01.nr-data.net",
  ...
}

This PR inroduces baecons as analytics parameters.

@auto-assign auto-assign bot requested a review from NGPixel September 13, 2021 17:21
@NGPixel
Copy link
Member

NGPixel commented Sep 13, 2021

You have a typo in your property names, should be "beacon", not "baecon". Also set the US values as default to help the user identify what it should look like (using default property).

@goto1134
Copy link
Contributor Author

@NGPixel, thank you for the suggestions! Can you check now?

@NGPixel NGPixel merged commit 94aab69 into requarks:dev Sep 15, 2021
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
…pport (requarks#4421)

* add beacon and error beacon newrelic parameters for eu region support
* add default NewRelic beacon URIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants