Fix display of Headers within Details Summary #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning up Headers within Details Summary
Fix for TOC Anchor location within Details Summary
broxen
changed the title
Fixed to accommodate larger summaries containing both headers and phrasing text. Still removing keylines for summaries with ONLY a header.
|
This really should be merged with #2502 to accommodate larger summaries. I've changed the CSS to accommodate the possibility of summaries containing headers and phrasing content, per the spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#the-summary-element With this latest revision, the key-line for headers only hides if the header is the only element child of the summary parent. |
NGPixel
approved these changes
Oct 2, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
* Header formatting for Details Summary Cleaning up Headers within Details Summary * Fix for TOC Anchor location Fix for TOC Anchor location within Details Summary * display: none for the keyline seems smarter * Fixes to accommodate large summaries Fixed to accommodate larger summaries containing both headers and phrasing text. Still removing keylines for summaries with ONLY a header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up Headers within Details Summary to fix an issue with display.
Modified app.scss with the following changes:
Let me know if there's anything else I should consider here.
Screenshot fixed:
