Adds displayName property to oidc authentication method #6096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
approved these changes
Jan 29, 2023
gueldenstone
added a commit
to gueldenstone/wiki
that referenced
this pull request
Feb 7, 2023
Relates to: requarks#6096
NGPixel
added a commit
that referenced
this pull request
Feb 8, 2023
* Fixes setting displayName from OIDC Relates to: #6096 * Update authentication.js --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
davidflypei
pushed a commit
to davidflypei/wiki
that referenced
this pull request
Jun 13, 2023
…ks#6096) * Adds displayName property to oidc authentication method * fix: update displayName prop * fix: use blank display name in oidc auth --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
davidflypei
pushed a commit
to davidflypei/wiki
that referenced
this pull request
Jun 13, 2023
* Fixes setting displayName from OIDC Relates to: requarks#6096 * Update authentication.js --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
…ks#6096) * Adds displayName property to oidc authentication method * fix: update displayName prop * fix: use blank display name in oidc auth --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
* Fixes setting displayName from OIDC Relates to: requarks#6096 * Update authentication.js --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when setting up the oidc authentication method, that it just uses the first part of the email (for my oidc provider authentik). In parallel to the oauth module I added the option to change the claim for the displayName so it can be set manually.