Change underlying lib to pyspnego #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need some more practical testing before this is merged. |
|
Have tested the changes from both a Linux, macOS, and Windows host against a Kerberos auth'd HTTP backend without any issues. Will release an rc of |
This was referenced Oct 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the underlying Kerberos library from
pykerberosandwinkerberostopyspnego. Thepyspnegolibrary handles the platforms differences between Windows and Linux meaning there is now only 1 dependency.Some other changes being made is designed to hide the underlying library used a bit more to avoid external libraries using it for their own purposes. This will ensure the kerb library can easily be changed in the future if need be.
The tests have been turned into
pytesttests as a few of the mocking functions needed to be changed due to the new API ofpyspnegocompared to the existing ones.