Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

541: updates pypi metadata in setup file #542

Conversation

jtroussard
Copy link
Contributor

Updates setup.py classifiers to match recent updates which drop support for older versions of python.

Left the broader version 3 without a minor version declared for visibility.

Release with 2.x.x

@coveralls
Copy link

Coverage Status

coverage: 90.097%. remained the same
when pulling 338c8a7 on 541-changelog-suggests-python-34-36-is-unsupported-but-project-metadata-allows-these-versions
into 7af9125 on master.

@JonathanHuot
Copy link
Contributor

JonathanHuot commented Mar 26, 2024

LGTM, which milestone/version should we set ? :)

@EpicWink
Copy link

My non-comprehensive testing does suggest that requests-oauthlib v2.0 works with Python 3.6, even if it's not supported and tested in CI, so it may not strictly be necessary to set python_requires=">=3.7". I personally don't mind either way.

@jtroussard
Copy link
Contributor Author

LGTM, which milestone/version should we set ? :)

This feels like a patch.

@jtroussard jtroussard added this to the 2.0.1 milestone Mar 27, 2024
@jtroussard
Copy link
Contributor Author

My non-comprehensive testing does suggest that requests-oauthlib v2.0 works with Python 3.6, even if it's not supported and tested in CI, so it may not strictly be necessary to set python_requires=">=3.7". I personally don't mind either way.

Perhaps there is a disconnect between what "works" and what is actively being supported???

Is there any appetite to pursue this 3.6 verification beyond @EpicWink 's efforts?

@EpicWink
Copy link

Perhaps there is a disconnect between what "works" and what is actively being supported???

I think that's exactly the case. If you want to avoid complaint GitHub issues in the future, I suggest keep the python_requires=">=3.7" change currently in the PR, but if you want to let users stray into the territory of the unsupported (and are happy to close occasional issues on the topic), then leave it.

I personally only update the python-requires metadata when my packages start to use syntax/functionality only available in later versions; pip should handle dependency resolution on transitive dependencies' python version requirements.

@jtroussard jtroussard merged commit 45eca1a into master Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog suggests Python 3.4-3.6 is unsupported, but project metadata allows these versions
5 participants