Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object data are not cleaned correctly when the property is removed #242

Closed
sebdeleze opened this issue Aug 21, 2020 · 0 comments · Fixed by #338
Closed

Object data are not cleaned correctly when the property is removed #242

sebdeleze opened this issue Aug 21, 2020 · 0 comments · Fixed by #338
Assignees
@jma
Labels
f: editor Concerns editor based on JSON schema AND custom editor

Comments

@sebdeleze
Copy link

sebdeleze commented Aug 21, 2020 •
edited
Loading

Describe the issue
When a document is saved with a required property, when we edit the document and the property is no more required and removed from editor, some data are kept when saving the document.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the document editor on sonardev.test.rero.ch
  2. Create a document with type Preprint and fill provisionActivity field with a start date.
  3. Edit the document and change the document type for Conference poster.
  4. Remove the provisionActivity property from editor.
  5. Try to save the document, a bad request is thrown from server.

Expected behavior
When the data are posted, they must not contain the provisionActivity field.

Screenshots
provision_activity
@sebdeleze sebdeleze mentioned this issue Aug 21, 2020
Closed
10 tasks
@sebdeleze sebdeleze added the f: editor Concerns editor based on JSON schema AND custom editor label Jan 12, 2021
jma added a commit to jma/ng-core that referenced this issue Jan 25, 2021
@jma
editor: fix issues
df0cdcc 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Jan 25, 2021
Merged
7 tasks
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
ba2a45f 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
0529063 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
3c53cb3 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
f289992 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 28, 2021
@jma
editor: fix issues
4198063 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed in #338 Feb 10, 2021
jma added a commit that referenced this issue Feb 10, 2021
@jma
editor: fix issues
ca9caf8 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes #328.
* Closes #327.
* Closes #325.
* Closes #248.
* Closes #242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: fix issues jma/ng-core
2 participants
@jma @sebdeleze