search: fix query search with brackets

[AoNoOokami]

• Allows queries with brackets and other specific symbols.
• Closes search: problem with brackets [ ] in the query rero-ils#755.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To close issue mentioned above.

How to test?

See issue description
Use npm link or npm pack to install this version of ng-core in rero-ils-ui (see https://github.com/rero/ng-core/blob/master/projects/rero/ng-core/README.md).

Code review check list

• Commit message template compliance.
• Commit message without typos.
• File names.
• Functions names.
• Functions docstrings.
• Unnecessary commited files?
• Extracted translations?

[AoNoOokami]

Reflexion: https://stackoverflow.com/a/332897

[sebdeleze]

The regex seems to be OK, but I juste suggest you to change the commit message for explaining that specials symbols will be replaced by spaces.

[benerken]

The fix works well.
But as explained yesterday, IMHO, we should find a more generic way to manage such case.
Like in your "reflexion" link here above :-) But I don't exactly which one to use :-\

[jma]

I think it is not the right approach. This remove the possibility to do expert search and I'm not sure that it is really robust. Imagine you have to search explicitly Title[subtitle]. This is a part of a more general US. This needs probably to change the use of the query_string to a simple_query_string in ES. We can imagine to use this PR as a quick fix. But we should not forget to remove this when a clean solution will be found.

[AoNoOokami]

I close this PR as discussed during sprint planning. The issue will be solve in another way after the analysis of the results of pilot tests and a reflexion about search query.