Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project: update properties and methods scopes #173

Merged
merged 1 commit into from
Apr 15, 2020
Merged

project: update properties and methods scopes #173

merged 1 commit into from
Apr 15, 2020

Conversation

sebdeleze
Copy link

project: update properties and methods scopes
97307e1 
* Removes "public" keyword for public methods and properties.
* Adds "_" before private methods and properties.
* Adds missing documentation blocks.
* Fixes adminMode in EditorComponent test.
* Closes #161.
* Closes #162.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze marked this pull request as ready for review April 15, 2020 11:35
@sebdeleze sebdeleze merged commit 1e9938e into rero:dev Apr 15, 2020
@sebdeleze sebdeleze deleted the sed-standardize branch April 15, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebdeleze