editor: fix 'oneOf' behaviour #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa#1603-issuance-maintype-subtype
branch
from
9502900 to
ccc3db0
Compare
7 tasks
AoNoOokami
force-pushed
the
zaa#1603-issuance-maintype-subtype
branch
from
ccc3db0 to
c560c5b
Compare
Garfield-fr
approved these changes
Jul 20, 2020
AoNoOokami
force-pushed
the
zaa#1603-issuance-maintype-subtype
branch
2 times, most recently
from
d7318a5 to
9fbb195
Compare
zannkukai
approved these changes
Jul 20, 2020
Fixes the behaviour of the editor with 'oneOf' schema property: for example, when selecting 'organisation' as author, the value of 'type' needed to be selected manually. Now the correct value of type is selected automatically. A similar behaviour is noted for 'mode of issuance' maintype and subtype. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
AoNoOokami
force-pushed
the
zaa#1603-issuance-maintype-subtype
branch
from
9fbb195 to
07c65a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the behaviour of the editor with 'oneOf' schema property: for
example, when selecting 'organisation' as author, the value of 'type'
needed to be selected manually. Now the correct value of type is
selected automatically. A similar behaviour is noted for 'mode of
issuance' maintype and subtype.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
This PR is part of US1432 (task 1603)
https://tree.taiga.io/project/rero21-reroils/us/1432?milestone=268117
https://tree.taiga.io/project/rero21-reroils/task/1603?kanban-status=1224894
How to test?
Needs rero/rero-ils#1097 and rero/rero-ils-ui#283
Login as a (system) librarian.
Go to the record editor.
Try several values for authors and mode of issuance.
If you try to edit an existing record, you'll find that the values are not correct, except for the default ones. This is reported here: rero/rero-ils#1102
Code review check list