Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: add ordered property for definitions #224

Merged
merged 1 commit into from
Jul 23, 2020
Merged

editor: add ordered property for definitions #224

merged 1 commit into from
Jul 23, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 22, 2020 •
edited
Loading

  • Adds ordered properties for JSONSchema definitions.
  • Fixes ordered properties for JSONSchema oneOf, anyOf.
  • Sets horizontal labels only for the long mode editor.

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-definitions-support branch from 5763b8d to 61adc3a Compare July 22, 2020 14:55
@jma jma changed the title Maj definitions support editor: add ordered property for definitions Jul 22, 2020
@jma jma requested a review from sebdeleze July 22, 2020 14:57
@jma jma marked this pull request as ready for review July 23, 2020 08:15
sebdeleze
sebdeleze suggested changes Jul 23, 2020
View reviewed changes
projects/rero/ng-core/src/lib/record/editor/utils.ts Outdated
orderedJsonSchema(item);
}
}
// recursion for allOf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad comment

@jma jma force-pushed the maj-definitions-support branch from 1d34029 to db9ffef Compare July 23, 2020 08:47
@jma jma requested a review from sebdeleze July 23, 2020 08:47
@jma
editor: add ordered property for definitions
40a3385 
* Adds ordered properties for JSONSchema definitions.
* Fixes ordered properties for JSONSchema oneOf, anyOf.
* Sets horizontal labels only for the long mode editor.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-definitions-support branch from db9ffef to 40a3385 Compare July 23, 2020 09:15
@sebdeleze sebdeleze merged commit 39836ad into rero:dev Jul 23, 2020
@jma jma deleted the maj-definitions-support branch December 13, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma @sebdeleze