records: handle errors #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
requested review from
jma and
Garfield-fr
and removed request for
Garfield-fr
* Improves errors handling in search, detail and edit views. * Adds an error component to display the error. * Adds an interface for error objects. * Removes `console.log` when a http error is catched. * Sends an error object with status and title when a http error occurs. * Types the parameters of subscribers to `getRecords` observable. * Exports error component for using it in host's projects. * Closes rero/sonar-ui#114. Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Garfield-fr
approved these changes
Jul 27, 2020
jma
approved these changes
Aug 17, 2020
| You should have received a copy of the GNU Affero General Public License | ||
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| --> | ||
| <div class="text-center my-5"> |
There was a problem hiding this comment.
why not using alerts or better https://valor-software.com/ngx-bootstrap/#/alerts?
| @@ -77,3 +77,4 @@ | |||
| </form> | |||
| </div> | |||
| </div> | |||
| <ng-core-error [error]="error" *ngIf="error"></ng-core-error> | |||
There was a problem hiding this comment.
why not in the main component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.logwhen a http error is catched.getRecordsobservable.