Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formly: improve id generator #238

Merged
merged 1 commit into from
Aug 18, 2020
Merged

formly: improve id generator #238

merged 1 commit into from
Aug 18, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Aug 17, 2020 •
edited
Loading

  • Adds numerical position on key generation for OneOf.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch

Why are you opening this PR?

  • Fix generate id on form field

How to test?

  • Check id on form

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr changed the title formly: improve id generate formly: improve id generator Aug 17, 2020
iGormilhit
iGormilhit suggested changes Aug 18, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit misses an explanation on why this commit is useful.

@Garfield-fr Garfield-fr requested a review from iGormilhit August 18, 2020 04:41
@iGormilhit iGormilhit added the f: editor Concerns editor based on JSON schema AND custom editor label Aug 18, 2020
@Garfield-fr Garfield-fr added this to the v0.12.0 (rero-ils) milestone Aug 18, 2020
@Garfield-fr @jma
formly: improve id generator
62f9300 
* Adds numerical position on key generation for OneOf.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
iGormilhit
iGormilhit approved these changes Aug 18, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr merged commit 3269511 into rero:dev Aug 18, 2020
@Garfield-fr Garfield-fr deleted the zub-fix-field-id branch September 7, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@lauren-d lauren-d lauren-d approved these changes

@AoNoOokami AoNoOokami Awaiting requested review from AoNoOokami

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.12.0 (rero-ils)
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @jma @iGormilhit @zannkukai @lauren-d