export: fix urlencode at export #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user clicks on Export Button, the user gets an error 400 because url was not encoded. Co-Authored-by: Benoit Erken <erken.benoit@gmail.com> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
approved these changes
Sep 16, 2020
lauren-d
approved these changes
Sep 16, 2020
Garfield-fr
approved these changes
Sep 16, 2020
sebdeleze
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user clicks on Export Button, he gets
an error 400 because url is not encoded.
Co-Authored-by: Benoit Erken erken.benoit@gmail.com
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
How to test?
and click on "Export as CSV". You should receive a file (and not an HTTP 400 Error)
Code review check list