Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: add tooltip on delete button of brief view #288

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Oct 23, 2020

  • Adds tooltip on delete button of the search view to inform the user why deletion is not possible.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@Garfield-fr Garfield-fr force-pushed the zub-fix-popover branch 2 times, most recently from f71565e to d7df874 Compare October 26, 2020 06:01
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

search: add tooltip on delete button of brief view

* Adds tooltip on delete button of the search view to inform the user why
  deletion is not possible.

* Adds tooltip on delete button of the search view to inform the user why
  deletion is not possible.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr changed the title result page: add tooltip on delete button search: add tooltip on delete button of brief view Oct 26, 2020
@Garfield-fr
Copy link
Contributor Author

Commit message proposition:

search: add tooltip on delete button of brief view

* Adds tooltip on delete button of the search view to inform the user why
  deletion is not possible.

done

@Garfield-fr Garfield-fr merged commit fb06912 into rero:dev Oct 26, 2020
@Garfield-fr Garfield-fr deleted the zub-fix-popover branch October 26, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants