records: add link to detail on brief view title #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankoworld
reviewed
Oct 23, 2019
| @@ -22,6 +22,8 @@ import { RecordSearchResultDirective } from './record-search-result.directive'; | |||
| import { JsonComponent } from './item/json.component'; | |||
| import { DialogService } from '../../../dialog/dialog.service'; | |||
| import { DeleteRecordStatus } from '../../record-status'; | |||
| import { map } from 'rxjs/operators'; | |||
There was a problem hiding this comment.
I think map is not used anymore.
* Injects detail URL in directive which manage result item display. * Provides example for displaying link to detail * Corrects error on certain documents details in tester. * Changes "patrons" key to "users" for displaying SONAR users in tester. * Fixes issue #23 Co-Authored-by: Olivier Dossmann <git@dossmann.net> Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Garfield-fr
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Olivier Dossmann git@dossmann.net
Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch