editor: fix options translation problems. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
Commit message proposition:
editor: fix options translation problems
Fixes two translations issues with the editor. When options for a select are defined as an
observable instead of an array, these options are not translated. Some of the option
properties could also be lost during the translation process.
Closes rero/rero-ils#1282
Fixes two translations issues with the editor. When options for a select are defined as an observable instead of an array, these options are not translated. Some of the option properties could also be lost during the translation process. Closes rero/rero-ils#1282 Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-observable-options-translations
branch
from
5c8b622 to
a874005
Compare
iGormilhit
approved these changes
Nov 19, 2020
jma
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two translations issues with the editor. When options for a select are defined as an
observable instead of an array, these options are not translated. Some of the option
properties could also be lost during the translation process.
Closes rero/rero-ils#1282
Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list