Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update and fix vulnerabilities #340

Merged
merged 1 commit into from
Jan 20, 2021
Merged

dependencies: update and fix vulnerabilities #340

merged 1 commit into from
Jan 20, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Jan 19, 2021

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma requested a review from sebdeleze January 19, 2021 07:53
@iGormilhit iGormilhit changed the title dependency: update and fix vulnerabilities dependencies: update and fix vulnerabilities Jan 19, 2021
iGormilhit
iGormilhit reviewed Jan 19, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title: dependency → dependencies.

@jma
dependencies: update and fix vulnerabilities
1797ce8 
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma requested a review from iGormilhit January 19, 2021 12:41
@jma jma force-pushed the maj-update-dependencies branch from 8a4746c to 1797ce8 Compare January 19, 2021 12:43
iGormilhit
iGormilhit approved these changes Jan 20, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@jma jma merged commit 10cb6af into rero:dev Jan 20, 2021
@jma jma deleted the maj-update-dependencies branch March 4, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @iGormilhit @sebdeleze