Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: add a config for resource context #357

Merged
merged 1 commit into from
Mar 10, 2021
Merged

resources: add a config for resource context #357

merged 1 commit into from
Mar 10, 2021

Conversation

sebdeleze
Copy link

@sebdeleze sebdeleze commented Mar 3, 2021

  • Adds a configuration in routing data to set the context for the resource. This is useful for using resources in the context of invenio-records-resources.
  • Uses id property of record instead of metadata.pid as this property not exists anymore with invenio-records-resources.
  • Displays a default title for resource if templateOptions.label is not set.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review March 3, 2021 14:42
@sebdeleze sebdeleze requested a review from jma March 3, 2021 14:43
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to adapt proxy data or the ng-core-tester?

@sebdeleze
Copy link
Author

Do we need to adapt proxy data or the ng-core-tester?

No, both the proxy and the tester work without change.

* Adds a configuration in routing data to set the context for the resource. This is useful for using resources in the context of `invenio-records-resources`.
* Uses `id` property of record instead of `metadata.pid` as this property not exists anymore with `invenio-records-resources`.
* Displays a default title for resource if `templateOptions.label` is not set.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 40d5022 into rero:dev Mar 10, 2021
@sebdeleze sebdeleze deleted the sed-new-resources-management branch March 10, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants