records: Fix external link issue #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
detailUrl is now an object containing the link and a boolean giving the information if link is external to angular routing or not. All custom components for brief views must be updated accordingly, I'm so sorry.. |
jma
approved these changes
Nov 6, 2019
* Returns an object representing the link instead of the link directly. * Removes icon for viewing resource detail. * Adds link to detail in JSON component. * Removes institution custom component for testing default JSON component. * Fixes issue #35 * Fixes issue #38 Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch