Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: fix aggregations filters error #427

Merged
merged 1 commit into from
Jul 27, 2021
Merged

search: fix aggregations filters error #427

merged 1 commit into from
Jul 27, 2021

Conversation

sebdeleze
Copy link

@sebdeleze sebdeleze commented Jul 23, 2021

Fixes an aggregations filters error appearing sometimes when filters
are empty (null). The issue is fixed by initializing filters to an
empty array.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review July 23, 2021 14:31
@sebdeleze sebdeleze requested review from jma and Garfield-fr July 23, 2021 14:31
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may check that the commit message body is hard wrapped a 72 chars.

@iGormilhit iGormilhit added this to the v1.5.0 milestone Jul 26, 2021
Fixes an aggregations filters error appearing sometimes when filters
are empty (null). The issue is fixed by initializing filters to an
empty array.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@jma
Copy link
Contributor

jma commented Jul 26, 2021

Tested on ils: OK!

@sebdeleze sebdeleze merged commit 8037c3a into rero:dev Jul 27, 2021
@sebdeleze sebdeleze deleted the sed-fix-agg-filters-error branch July 27, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants