Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: check adminMode value in detail component #44

Merged
merged 1 commit into from
Nov 11, 2019
Merged

resources: check adminMode value in detail component #44

merged 1 commit into from
Nov 11, 2019

Conversation

sebdeleze
Copy link

  • Checks adminMode value in detail component for showing or hiding edition and deletion button.
  • Floats right the buttons instead of using a grid column in brief view and detail view.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze requested review from jma and Garfield-fr November 8, 2019 07:57
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the impression that this is already in an other PR, no?

</div>
<div class="col-3 text-right" *ngIf="record">
<a href class="btn btn-sm btn-primary" routerLink="../../edit/{{ record.metadata.pid }}"
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this div required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not required, I removed it

* Checks adminMode value in detail component for showing or hiding edition and deletion button.
* Floats right the buttons instead of using a grid column in brief view and detail view.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 3707113 into rero:dev Nov 11, 2019
@sebdeleze sebdeleze deleted the sed-admin-mode branch November 11, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants