Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: add new service to personalized title and meta html #85

Merged
merged 1 commit into from
Dec 19, 2019
Merged

service: add new service to personalized title and meta html #85

merged 1 commit into from
Dec 19, 2019
+219 −6

Conversation

Garfield-fr
Copy link
Contributor

  • Adds service for title and meta html
  • Adds new parameter prefixWidow on config
  • Implements this service on ng-core-tester

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • to add possibility to modify title and meta on head html

How to test?

  • Check title on tab

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

zannkukai
zannkukai approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefixWidow instead of prefixWindow in commit and git message :p

@Garfield-fr
service: add new service to personalized title and meta html
91991ea 
* Adds service for title and meta html.
* Adds new parameter prefixWindow on config.
* Implements this service on ng-core-tester.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr
Copy link
Contributor Author

prefixWidow instead of prefixWindow in commit and git message :p

done

@sebdeleze sebdeleze merged commit e58705f into rero:dev Dec 19, 2019
@Garfield-fr Garfield-fr deleted the zub-title-meta branch December 20, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

@benerken benerken Awaiting requested review from benerken

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @sebdeleze @zannkukai @AoNoOokami