title: refactoring MainTitle service as a pipe.

Refactoring MainTitleService as a pipe. It allows to use it more easely
into components because we don't need to importt the service and create
repetitive memthod in each component to get a document main title

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>

projects/admin/src/app/circulation/checkin/checkin.component.spec.ts

@@ -23,13 +23,14 @@ import { TranslateModule } from '@ngx-translate/core';
 import { CoreModule, RecordModule } from '@rero/ng-core';
 import { CollapseModule } from 'ngx-bootstrap';
 import { UserService } from '../../service/user.service';
+import { SharedPipesModule } from '../../shared/shared-pipes.module';
 import { ItemComponent } from '../item/item.component';
 import { ItemsListComponent } from '../items-list/items-list.component';
 import { CardComponent } from '../patron/card/card.component';
 import { CheckinComponent } from './checkin.component';
 
 
-describe('CheckoutComponent', () => {
+describe('CheckinComponent', () => {
   let component: CheckinComponent;
   let fixture: ComponentFixture<CheckinComponent>;
 
@@ -58,7 +59,8 @@ describe('CheckoutComponent', () => {
         HttpClientModule,
         RouterTestingModule,
         CollapseModule,
-        BrowserAnimationsModule
+        BrowserAnimationsModule,
+        SharedPipesModule
       ],
       declarations: [
         CardComponent,

projects/admin/src/app/circulation/item/item.component.html

@@ -31,8 +31,8 @@
   <!-- TITLE -->
   <div class="col-lg-4"><a
       [routerLink]="['/records','documents','detail', item.document.pid]"
-      *ngIf="getMainTitle(item.document.title) != null">
-      {{ getMainTitle(item.document.title) | truncateText: 12 }}</a>
+      *ngIf="(item.document.title | mainTitle) != null">
+      {{ item.document.title | mainTitle | truncateText: 12 }}</a>
   </div>
   <!-- CIRCULATION INFO -->
   <div class="col-lg-3">

projects/admin/src/app/circulation/item/item.component.spec.ts

@@ -1,14 +1,14 @@
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { ItemComponent } from './item.component';
-import { TranslateModule } from '@ngx-translate/core';
+import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
+import { CollapseModule } from 'ngx-bootstrap';
 import { CoreModule, RecordModule } from '@rero/ng-core';
-import { RouterTestingModule } from '@angular/router/testing';
 import { HttpClientModule } from '@angular/common/http';
-import { CollapseModule } from 'ngx-bootstrap';
-import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
-import { LoanComponent } from '../patron/loan/loan.component';
+import { RouterTestingModule } from '@angular/router/testing';
+import { TranslateModule } from '@ngx-translate/core';
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { ItemComponent } from './item.component';
 import { ItemsListComponent } from '../items-list/items-list.component';
+import { LoanComponent } from '../patron/loan/loan.component';
+import { SharedPipesModule } from '../../shared/shared-pipes.module';
 
 describe('ItemComponent', () => {
   let component: ItemComponent;
@@ -23,7 +23,8 @@ describe('ItemComponent', () => {
         RouterTestingModule,
         HttpClientModule,
         CollapseModule,
-        BrowserAnimationsModule
+        BrowserAnimationsModule,
+        SharedPipesModule
       ],
       declarations: [
         LoanComponent,

projects/admin/src/app/circulation/item/item.component.ts

@@ -19,7 +19,6 @@ import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
 import { RecordService } from '@rero/ng-core';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
-import { MainTitleService } from '../../service/main-title.service';
 import { OrganisationService } from '../../service/organisation.service';
 import { Item, ItemAction, Loan, LoanState } from '../items';
 import { PatronTransactionService } from '../patron-transaction.service';
@@ -66,8 +65,7 @@ export class ItemComponent implements OnInit {
   constructor(
     private recordService: RecordService,
     private organisationService: OrganisationService,
-    private patronTransactionService: PatronTransactionService,
-    private _mainTitleService: MainTitleService
+    private patronTransactionService: PatronTransactionService
     ) {  }
 
   /**
@@ -124,12 +122,4 @@ export class ItemComponent implements OnInit {
   get organisation() {
     return this.organisationService.organisation;
   }
-
-  /**
-   * Get main title (correspondig to 'bf_Title' type, present only once in metadata)
-   * @param titleMetadata: title metadata
-   */
-  getMainTitle(titleMetadata: any): string {
-    return this._mainTitleService.getMainTitle(titleMetadata);
-  }
 }

projects/admin/src/app/circulation/items-list/items-list.component.spec.ts

@@ -15,16 +15,17 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { ItemsListComponent } from './items-list.component';
+import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
+import { CollapseModule } from 'ngx-bootstrap';
+import { CoreModule, RecordModule } from '@rero/ng-core';
+import { HttpClientModule } from '@angular/common/http';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
-import { CoreModule, RecordModule } from '@rero/ng-core';
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { ItemComponent } from '../item/item.component';
-import { HttpClientModule } from '@angular/common/http';
-import { CollapseModule } from 'ngx-bootstrap';
-import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
+import { ItemsListComponent } from './items-list.component';
+import { SharedPipesModule } from '../../shared/shared-pipes.module';
+
 
 describe('ItemsListComponent', () => {
   let component: ItemsListComponent;
@@ -39,7 +40,8 @@ describe('ItemsListComponent', () => {
         RecordModule,
         HttpClientModule,
         CollapseModule,
-        BrowserAnimationsModule
+        BrowserAnimationsModule,
+        SharedPipesModule
       ],
       declarations: [
         ItemsListComponent,

projects/admin/src/app/circulation/main-request/main-request.component.spec.ts

@@ -20,16 +20,23 @@ import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { RecordModule } from '@rero/ng-core';
-import { RequestedItemsListComponent } from '../requested-items-list/requested-items-list.component';
 import { MainRequestComponent } from './main-request.component';
+import { RequestedItemsListComponent } from '../requested-items-list/requested-items-list.component';
+import { SharedPipesModule } from '../../shared/shared-pipes.module';
 
 describe('MainRequestComponent', () => {
   let component: MainRequestComponent;
   let fixture: ComponentFixture<MainRequestComponent>;
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
-      imports: [RecordModule, RouterTestingModule, HttpClientModule, TranslateModule.forRoot()],
+      imports: [
+        RecordModule,
+        RouterTestingModule,
+        HttpClientModule,
+        TranslateModule.forRoot(),
+        SharedPipesModule
+      ],
       declarations: [ MainRequestComponent, RequestedItemsListComponent ]
     })
     .compileComponents();

projects/admin/src/app/circulation/main-request/main-request.component.ts

@@ -24,8 +24,7 @@ import { ItemsService } from '../items.service';
 
 @Component({
   selector: 'admin-circulation-main-request',
-  templateUrl: './main-request.component.html',
-  styleUrls: ['./main-request.component.scss']
+  templateUrl: './main-request.component.html'
 })
 export class MainRequestComponent implements OnInit {
 

projects/admin/src/app/circulation/patron/history/history-item/history-item.component.html

@@ -25,12 +25,12 @@
         <i [ngClass]="{ 'fa-caret-down': !isCollapsed, 'fa-caret-right': isCollapsed }" class="fa" aria-hidden="true"></i>
       </button>
       <a [routerLink]="['/records','documents','detail', document.metadata.pid]"
-         *ngIf="getMainTitle(document.metadata.title) != null">
+         *ngIf="(document.metadata.title | mainTitle) != null">
         <ng-container *ngIf="isCollapsed; else titleNotCollapsed">
-          {{ getMainTitle(document.metadata.title) | truncateText: 10 }}
+          {{ document.metadata.title | mainTitle | truncateText: 10 }}
         </ng-container>
         <ng-template #titleNotCollapsed>
-          {{ getMainTitle(document.metadata.title) }}
+          {{ document.metadata.title | mainTitle }}
         </ng-template>
       </a>
     </div>

projects/admin/src/app/circulation/patron/history/history-item/history-item.component.ts

@@ -2,7 +2,6 @@ import { Component, Input, OnInit } from '@angular/core';
 import { extractIdOnRef, RecordService } from '@rero/ng-core';
 import { forkJoin } from 'rxjs';
 import { ProvisionActivityType } from '../../../../pipe/provision-activity.pipe';
-import { MainTitleService } from '../../../../service/main-title.service';
 import { PatronService } from '../../../../service/patron.service';
 
 @Component({
@@ -36,8 +35,7 @@ export class HistoryItemComponent implements OnInit {
    */
   constructor(
     private _recordService: RecordService,
-    private _patronService: PatronService,
-    private _mainTitleService: MainTitleService
+    private _patronService: PatronService
   ) { }
 
   /**
@@ -63,14 +61,4 @@ export class HistoryItemComponent implements OnInit {
         });
     }
   }
-
-  /**
-   * Get main title (corresponding to 'bf_Title' type, present only once in metadata)
-   * @param titleMetadata: title metadata
-   * @return string: the document main title, `null` if not found
-   */
-  getMainTitle(titleMetadata: any): string {
-    return this._mainTitleService.getMainTitle(titleMetadata);
-  }
-
 }

projects/admin/src/app/circulation/patron/loan/loan.component.spec.ts

@@ -17,16 +17,15 @@
 
 import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { CoreModule, RecordModule } from '@rero/ng-core';
+import { CollapseModule } from 'ngx-bootstrap';
+import { ItemComponent } from '../../item/item.component';
 import { ItemsListComponent } from '../../items-list/items-list.component';
 import { LoanComponent } from './loan.component';
-import { ItemComponent } from '../../item/item.component';
-import { ItemsService } from '../../items.service';
-import { ToastrService } from 'ngx-toastr';
-import { CollapseModule } from 'ngx-bootstrap';
-import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
+import { SharedPipesModule } from '../../../shared/shared-pipes.module';
 import { UserService } from '../../../service/user.service';
 
 
@@ -59,7 +58,8 @@ describe('LoanComponent', () => {
         RouterTestingModule,
         HttpClientModule,
         CollapseModule,
-        BrowserAnimationsModule
+        BrowserAnimationsModule,
+        SharedPipesModule
       ],
       declarations: [
         LoanComponent,

projects/admin/src/app/circulation/patron/patron-transactions/patron-transaction-event-form/patron-transaction-event-form.component.spec.ts

@@ -1,13 +1,12 @@
+import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { PatronTransactionEventFormComponent } from './patron-transaction-event-form.component';
 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
+import { RouterTestingModule } from '@angular/router/testing';
 import { FormlyModule } from '@ngx-formly/core';
-import { CoreModule } from '@rero/ng-core';
 import { TranslateModule } from '@ngx-translate/core';
-import { HttpClientModule } from '@angular/common/http';
+import { CoreModule } from '@rero/ng-core';
 import { BsModalRef } from 'ngx-bootstrap';
-import { RouterTestingModule } from '@angular/router/testing';
+import { PatronTransactionEventFormComponent } from './patron-transaction-event-form.component';
 
 describe('PatronTransactionEventFormComponent', () => {
   let component: PatronTransactionEventFormComponent;

projects/admin/src/app/circulation/patron/patron-transactions/patron-transaction-event/patron-transaction-event.component.spec.ts

@@ -1,9 +1,8 @@
+import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
+import { TranslateModule } from '@ngx-translate/core';
 import { CoreModule, RecordModule } from '@rero/ng-core';
 import { PatronTransactionEventComponent } from './patron-transaction-event.component';
-import { HttpClientModule } from '@angular/common/http';
-import { TranslateModule } from '@ngx-translate/core';
 
 describe('PatronTransactionEventComponent', () => {
   let component: PatronTransactionEventComponent;

projects/admin/src/app/circulation/patron/patron-transactions/patron-transaction/patron-transaction.component.html

@@ -31,8 +31,8 @@ <h6 translate>Details</h6>
           <div class="col-sm-2 label-title text-right" translate>Document</div>
           <div class="col-sm-10">
             <a [routerLink]="['/records','documents','detail', transaction.document.pid]"
-              *ngIf="getMainTitle(document.metadata.title) != null">
-              {{ getMainTitle(document.metadata.title) | truncateText: 15 }}
+              *ngIf="(document.metadata.title | mainTitle) != null">
+              {{ document.metadata.title | mainTitle | truncateText: 15 }}
             </a>
           </div>
         </div>

projects/admin/src/app/circulation/patron/patron-transactions/patron-transaction/patron-transaction.component.spec.ts

@@ -1,12 +1,12 @@
+import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { PatronTransactionComponent } from './patron-transaction.component';
-import { CoreModule, RecordModule } from '@rero/ng-core';
+import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { RouterTestingModule } from '@angular/router/testing';
-import { PatronTransactionEventComponent } from '../patron-transaction-event/patron-transaction-event.component';
-import { HttpClientModule } from '@angular/common/http';
 import { TranslateModule } from '@ngx-translate/core';
-import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
+import { CoreModule, RecordModule } from '@rero/ng-core';
+import { SharedPipesModule } from '../../../../shared/shared-pipes.module';
+import { PatronTransactionEventComponent } from '../patron-transaction-event/patron-transaction-event.component';
+import { PatronTransactionComponent } from './patron-transaction.component';
 
 describe('PatronTransactionComponent', () => {
   let component: PatronTransactionComponent;
@@ -20,7 +20,8 @@ describe('PatronTransactionComponent', () => {
         RouterTestingModule,
         HttpClientModule,
         TranslateModule.forRoot(),
-        BrowserAnimationsModule
+        BrowserAnimationsModule,
+        SharedPipesModule
       ],
       declarations: [
         PatronTransactionComponent,

projects/admin/src/app/circulation/patron/patron-transactions/patron-transaction/patron-transaction.component.ts

@@ -1,7 +1,6 @@
 import { Component, Input, OnInit } from '@angular/core';
 import { RecordService } from '@rero/ng-core';
 import { BsModalService } from 'ngx-bootstrap';
-import { MainTitleService } from 'projects/admin/src/app/service/main-title.service';
 import { map, mergeMap } from 'rxjs/operators';
 import { OrganisationService } from '../../../../service/organisation.service';
 import { Item } from '../../../items';
@@ -31,8 +30,7 @@ export class PatronTransactionComponent implements OnInit {
     private _recordService: RecordService,
     private _organisationService: OrganisationService,
     private _patronTransactionService: PatronTransactionService,
-    private _modalService: BsModalService,
-    private _mainTitleService: MainTitleService
+    private _modalService: BsModalService
   ) {}
 
   ngOnInit() {
@@ -110,12 +108,4 @@ export class PatronTransactionComponent implements OnInit {
     };
     this._modalService.show(PatronTransactionEventFormComponent, {initialState});
   }
-
-  /**
-   * Get main title (correspondig to 'bf_Title' type, present only once in metadata)
-   * @param titleMetadata: title metadata
-   */
-  getMainTitle(titleMetadata: any): string {
-    return this._mainTitleService.getMainTitle(titleMetadata);
-  }
 }

projects/admin/src/app/circulation/patron/patron-transactions/patron-transactions.component.spec.ts

@@ -1,12 +1,12 @@
+import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { PatronTransactionsComponent } from './patron-transactions.component';
+import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
-import { PatronTransactionComponent } from './patron-transaction/patron-transaction.component';
 import { CoreModule, RecordModule } from '@rero/ng-core';
-import { RouterTestingModule } from '@angular/router/testing';
+import { SharedPipesModule } from '../../../shared/shared-pipes.module';
 import { PatronTransactionEventComponent } from './patron-transaction-event/patron-transaction-event.component';
-import { HttpClientModule } from '@angular/common/http';
+import { PatronTransactionComponent } from './patron-transaction/patron-transaction.component';
+import { PatronTransactionsComponent } from './patron-transactions.component';
 
 describe('PatronTransactionsComponent', () => {
   let component: PatronTransactionsComponent;
@@ -19,7 +19,8 @@ describe('PatronTransactionsComponent', () => {
         CoreModule,
         RecordModule,
         RouterTestingModule,
-        HttpClientModule
+        HttpClientModule,
+        SharedPipesModule
       ],
       declarations: [
         PatronTransactionsComponent,