project: Libraries dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NEW Add dependencies needed by ng-core. * NEW Add routing to both applications. * NEW Add record search for testing purpose. * BETTER Change scripts in package.json. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Garfield-fr
approved these changes
Sep 27, 2019
AoNoOokami
approved these changes
Sep 30, 2019
jma
approved these changes
Sep 30, 2019
| "test": "ng test admin && ng test public-search", | ||
| "lint": "ng lint admin && ng lint public-search", | ||
| "e2e": "ng e2e admin && ng e2e public-search" | ||
| "test": "ng test", |
There was a problem hiding this comment.
Is these tests run the two projects?
There was a problem hiding this comment.
yes, both tests are running with "ng test" command
|
Does not work with rero-ils and the npm version of @rero/ng-core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch