Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

item: update status after request #1039

Merged
merged 1 commit into from
Oct 4, 2023
Merged

item: update status after request #1039

merged 1 commit into from
Oct 4, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr self-assigned this Sep 21, 2023
@github-actions github-actions bot added the f: professional ui Professional interface label Sep 21, 2023
@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 25, 2023 •
edited
Loading

PO tests

  • Doesn't seem to work (Firefox), error in console
    image

@github-actions github-actions bot added f: search f: public ui Public interface, as opposed to the professional interface labels Sep 27, 2023
jma
jma approved these changes Oct 4, 2023
View reviewed changes
projects/admin/src/app/service/items.service.ts Outdated
* @param pid - String
* @returns Observable<any>
*/
getEsItemByPid(pid: string): Observable<any> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this to getByPidFromEs or similar, Item is already in the service name.

@Garfield-fr
item: update status after request
efc2374 
* Closes rero/rero-ils#2314.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 652f190 into rero:staging Oct 4, 2023
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-item-status branch October 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@jma jma jma approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@Garfield-fr Garfield-fr

Labels
f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

admin interface: The status of the item is not updated after a request
4 participants
@Garfield-fr @PascalRepond @jma @lauren-d