fees: fix error on display #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
reviewed
Sep 21, 2023
| @@ -16,7 +16,9 @@ | |||
| along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| --> | |||
| <div class="description container pl-0"> | |||
| <h5 class="mb-0">{{ parent.note }}</h5> | |||
| <h5 *ngIf="parent.note" class="mb-0"> | |||
| [{{ 'Note' | translate }}: {{ parent.note }}] | |||
There was a problem hiding this comment.
[Note: here_comes_parent_note_content] string seems strange for me. Is it a PO request ?
There was a problem hiding this comment.
A request from @ManaDeweerdt .She thinks it's weird to have a note as a title, so she wanted to differentiate.
...ef-view/patron-transaction-events-brief-view/patron-transaction-event-overdue.component.html
Outdated
Show resolved
Hide resolved
In the case of manual charges, there is no document and no item. We display either the note or the type. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-fees-brief-view
branch
from
63a5b83 to
18f767f
Compare
PascalRepond
approved these changes
Sep 25, 2023
zannkukai
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of manual charges, there is no document and no item. We display either the note or the type.
Code review check list