Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: fix patron barcode #1045

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

Garfield-fr
Copy link
Contributor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this Sep 28, 2023
@github-actions github-actions bot added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend labels Sep 28, 2023
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr changed the title circulation: fix patron barcode on checkin screen circulation: fix patron barcode Oct 2, 2023
@Garfield-fr Garfield-fr requested a review from jma October 3, 2023 09:18
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our consortium, patrons could have multiple barcodes. This is why barcode field is an array.
Using your changes, it should be failed ? Isn't it ?

@Garfield-fr
Copy link
Contributor Author

In our consortium, patrons could have multiple barcodes. This is why barcode field is an array. Using your changes, it should be failed ? Isn't it ?

The API now returns only the first barcode, because in the code we always did [0].

@Garfield-fr Garfield-fr merged commit 7d40988 into rero:staging Oct 3, 2023
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-item-patron-barcode-fix branch October 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants