Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libraies: add editor validation #1082

Merged
merged 1 commit into from
Nov 23, 2023
Merged

libraies: add editor validation #1082

merged 1 commit into from
Nov 23, 2023

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 22, 2023

  • Adds library editor validators for notification settings.
  • Display facettes in the stat config editor when no result occurs.

@github-actions github-actions bot added f: professional ui Professional interface f: editor Concerns editor based on JSON schema AND custom editor labels Nov 22, 2023
@jma jma marked this pull request as ready for review November 23, 2023 07:52
zannkukai
zannkukai approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo into commit message : 'libraies' and 'facettes' --> "libraries" & "facets"

@jma
libraries: add editor validation
ecc4c14 
* Adds library editor validators for notification settings.
* Display facets in the stat config editor when no result occurs.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-fix-lib-editor-validation branch from 672ed4b to ecc4c14 Compare November 23, 2023 09:26
@jma
Copy link
Contributor Author

jma commented Nov 23, 2023

small typo into commit message : 'libraies' and 'facettes' --> "libraries" & "facets"

Th

small typo into commit message : 'libraies' and 'facettes' --> "libraries" & "facets"

Thanks for your awk eyes!

@PascalRepond PascalRepond merged commit b81df23 into rero:staging Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @Garfield-fr @zannkukai @PascalRepond