Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circulation): display check-in note #1130

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat(circulation): display check-in note #1130

merged 1 commit into from
Mar 5, 2024

Conversation

Garfield-fr
Copy link
Contributor

The check-in note is displayed when an item arrives from transit.

@Garfield-fr Garfield-fr self-assigned this Feb 29, 2024
@github-actions github-actions bot added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend labels Feb 29, 2024
@PascalRepond
Copy link
Contributor

Tests

  • [not-blocking] The checkin note is now also displayed in external library when receving the item from transit_for_pickup, which is not useful.
    • Maybe the checkin note on receive should be displayed only if the item is scanned in its owning library.
  • [not-blocking] When a receive action is performed, the checkin note is displayed in the warning toaster but not in the circulation line.
    image

@Garfield-fr
feat(circulation): display check-in note
ab8bcd2 
The check-in note is displayed when an item arrives from transit.

* Closes rero/rero-ils#3610.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 7b9ed6b into rero:staging Mar 5, 2024
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-checkin-note branch March 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@jma jma jma approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@Garfield-fr Garfield-fr

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkin note should be displayed when an item is scanned in its owning library
3 participants
@Garfield-fr @PascalRepond @jma