Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detail views enhancements #1135

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr self-assigned this Mar 5, 2024
@github-actions github-actions bot added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend f: activity-logs Everything around logging user activities labels Mar 5, 2024
@Garfield-fr Garfield-fr force-pushed the zub-detail-view-enhancements branch 3 times, most recently from 2b222f7 to eb2d7e5 Compare March 5, 2024 07:39
@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 5, 2024

Tests PO

  • REP: Item detailed view: "Local fields" tab label is not translated?
  • REP: Item detailed view: "Borrowed by" box should be hidden if it is empty (cf. before 1.21.0)
  • REP [not-linked but could be fixed in the flow] Item-ISSUE detailed view: the back buttons are weirdly displayed
    Now:
    image
    Before:
    image

Copy link
Contributor

@PascalRepond PascalRepond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

translate>Import</button>
>
<i class="fa fa-cloud-download"></i>
{{ 'Import' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translate pipe for 'Import'

})
export class HoldingPageDetailComponent extends DetailComponent {

get isEnabledOperationLog(): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing docstrings

})
export class ItemPageDetailComponent extends DetailComponent {

get isEnabledOperationLog(): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing docstrings

@Garfield-fr Garfield-fr force-pushed the zub-detail-view-enhancements branch 2 times, most recently from b0a4e85 to f8c30a0 Compare March 12, 2024 14:33
* Closes rero/rero-ils#3618.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 69423cc into rero:staging Mar 13, 2024
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-detail-view-enhancements branch March 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: activity-logs Everything around logging user activities f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pro resources detailed views: enhancements
3 participants