-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detail views enhancements #1135
feat: detail views enhancements #1135
Conversation
Garfield-fr
commented
Mar 5, 2024
- Closes Pro resources detailed views: enhancements rero-ils#3618.
2b222f7
to
eb2d7e5
Compare
eb2d7e5
to
5af15f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
translate>Import</button> | ||
> | ||
<i class="fa fa-cloud-download"></i> | ||
{{ 'Import' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translate
pipe for 'Import'
}) | ||
export class HoldingPageDetailComponent extends DetailComponent { | ||
|
||
get isEnabledOperationLog(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing docstrings
}) | ||
export class ItemPageDetailComponent extends DetailComponent { | ||
|
||
get isEnabledOperationLog(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing docstrings
b0a4e85
to
f8c30a0
Compare
* Closes rero/rero-ils#3618. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
f8c30a0
to
c5f4105
Compare