Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(circulation): add informations message #1146

Merged

Conversation

Garfield-fr
Copy link
Contributor

During a check-in, if the item is in a collection and at a temporary location, and if the item belongs to the current library, this information is added to the message intended for the professional.

Dependencies

@Garfield-fr Garfield-fr self-assigned this Mar 26, 2024
@github-actions github-actions bot added f: professional ui Professional interface f: search f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management labels Mar 26, 2024
@Garfield-fr Garfield-fr force-pushed the zub-checkin-circulation-infos branch from 8301e1b to 72ec0cd Compare March 27, 2024 12:21
@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 28, 2024

Tests

  • REP: Unwanted commas are added on the line for exhibition info
    image
  • REP: If item is in multiple collections, I have no way to know, no "and X others" like in the specs.

During a check-in, if the item is in a collection and at a temporary
location, and if the item belongs to the current library,
this information is added to the message intended for the professional.

* Closes rero/rero-ils#1321.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-checkin-circulation-infos branch from 72ec0cd to 6929d13 Compare March 28, 2024 08:03
@Garfield-fr Garfield-fr merged commit c4e3726 into rero:staging Apr 2, 2024
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-checkin-circulation-infos branch April 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash message at the check-in if the item in an active exhibition/course or in a temporary location
4 participants