feat(item): add fees on item detail view #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Garfield-fr
commented
Apr 9, 2024
Garfield-fr
commented
- Adds fees on item detail view.
- Changes patron link on fees brief view to redirect to the patron circulation fees tab.
- Closes Add in the item view a way to see the linked fees rero-ils#3578.
benerken
approved these changes
Apr 9, 2024
Garfield-fr
force-pushed
the
zub-fees
branch
3 times, most recently
from
cc9493c
to
40f92fe
Compare
github-actions
bot
added
f: circulation
PascalRepond
approved these changes
Apr 9, 2024
rerowep
approved these changes
Apr 9, 2024
jma
approved these changes
Apr 9, 2024
| <div class="card-header"> | ||
| <b translate>Fees</b> | ||
| <div class="float-right"> | ||
| <span class="font-weight-bold mr-2">{{ 'Total' | translate }}</span> |
| * @param organisationService - OrganisationService | ||
| */ | ||
| public constructor( | ||
| private patronTransactionApiService: PatronTransactionApiService, |
There was a problem hiding this comment.
Do you want to use the @Inject method?
There was a problem hiding this comment.
I suggest we refactor these injections later.
* Adds fees on item detail view. * Changes patron link on fees brief view to redirect to the patron circulation fees tab. * Closes rero/rero-ils#3578. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.