Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item: hide action button on item if the user is not in the same library #137

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

Garfield-fr
Copy link
Contributor

  • Improves action on item (hide action if user is not in the same library).
  • Fixes remove key available on preUpdateRecord.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

How to test?

  • Check action on page document (section items)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Improves action on item (hide action if user is not in the same library).
* Fixes remove key available on preUpdateRecord.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
</ng-template>
</ng-container>
<ng-template #noactions>
&nbsp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is necessary ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't put a space in the div tag, no space is effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants