Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: correct pickup location for actions #152

Merged
merged 1 commit into from
Feb 12, 2020
Merged

circulation: correct pickup location for actions #152

merged 1 commit into from
Feb 12, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Feb 11, 2020 •
edited
Loading

  • Adds current library pid as parameter to apply actions.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

Corrects 33. of #108

How to test?

Needs rero/rero-ils#749
As a system librarian (for example Astrid):

  1. Do a checkin in an other library than the item's home library to put an item in transit.
  2. Switch to the destination library.
  3. Then scan the barcode. Item should be on shelf.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@benerken benerken mentioned this pull request Feb 11, 2020
Closed
51 tasks
@AoNoOokami AoNoOokami marked this pull request as ready for review February 11, 2020 13:55
@jma
circulation: correct pickup location for actions
cb092eb 
* Adds current library pid as parameter to apply actions.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-circulation-ui-correction branch from 9416540 to cb092eb Compare February 12, 2020 07:01
@AoNoOokami AoNoOokami added this to the v0.6.0 milestone Feb 12, 2020
@AoNoOokami AoNoOokami merged commit 42470e3 into rero:dev Feb 12, 2020
@AoNoOokami AoNoOokami deleted the zaa-circulation-ui-correction branch February 12, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0 rero-ils
Development

Successfully merging this pull request may close these issues.
3 participants
@AoNoOokami @Garfield-fr @sebdeleze