circulation: Fees tab implementation #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
12 times, most recently
from
a4342b7
to
cf2c143
Compare
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
9 times, most recently
from
d026376
to
db1bfac
Compare
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
5 times, most recently
from
47231e4
to
c10ead7
Compare
AoNoOokami
approved these changes
Feb 26, 2020
| <h5 class="card-title">{{ transaction.type }}</h5> | ||
| <div class="card-text"> | ||
| <div class="row" *ngIf="transaction.note"> | ||
| <label class="col-4 label-title" translate>Note</label> |
There was a problem hiding this comment.
In the other views, we used col-lg-* or col-md-* for responsiveness. Just check the behaviour on small screen devices.
(EDIT: maybe not relevant here).
benerken
approved these changes
Feb 26, 2020
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
from
c10ead7
to
c4bfb8e
Compare
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
from
c4bfb8e
to
6861c79
Compare
sebdeleze
suggested changes
Mar 3, 2020
...on/patron/patron-transactions/patron-transaction-event/patron-transaction-event.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/patron/main/main.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/patron/main/main.component.ts
Outdated
Show resolved
Hide resolved
...patron-transactions/patron-transaction-event-form/patron-transaction-event-form.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/patron/patron-transactions/patron-transactions.component.ts
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
2 times, most recently
from
fd62792
to
e6ad1bd
Compare
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
from
e6ad1bd
to
e41c798
Compare
sebdeleze
approved these changes
Mar 3, 2020
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
7 times, most recently
from
070b8da
to
aa69f5f
Compare
* Implements Fee tab for a patron account. * Adapts existing features concerning fees. * Create PatronTransaction service. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#1255-patron-transaction-tabs
branch
from
aa69f5f
to
20a4316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
How to test?
Use the
rero_ils.US659branch.Code review check list