Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: add "show more" link #166

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Conversation

zannkukai
Copy link
Contributor

Co-Authored-by: Benoit Erken erken.benoit@gmail.com
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • Find a document with a long abstract. You should see the first 100 words, then a "show more" link to display the full content of abstract.

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Feb 17, 2020
@zannkukai zannkukai assigned benerken and unassigned zannkukai Feb 17, 2020
@zannkukai zannkukai force-pushed the ucl-text-truncate branch 3 times, most recently from 1ef5d57 to 89df8f7 Compare February 19, 2020 08:08
@zannkukai zannkukai force-pushed the ucl-text-truncate branch 5 times, most recently from 1449e34 to 0c22005 Compare March 9, 2020 08:59
@zannkukai zannkukai force-pushed the ucl-text-truncate branch 3 times, most recently from eb08602 to 9af139d Compare March 18, 2020 09:25
* use ng-core component "read-more" to truncate text and add a "show more" link to abstract.

Co-Authored-by: Benoit Erken <erken.benoit@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 1b82fde into rero:dev Mar 24, 2020
@zannkukai zannkukai deleted the ucl-text-truncate branch March 24, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants