circulation: display library name while transit #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankoworld
force-pushed
the
doo-769-fix-library-name
branch
from
bacbb08
to
80033f3
Compare
Garfield-fr
approved these changes
Feb 20, 2020
zannkukai
reviewed
Feb 20, 2020
| @@ -41,7 +41,7 @@ $ git clone https://github.com/rero/rero-ils-ui.git/ | |||
| $ cd rero-ils-ui | |||
| $ nvm use lts/dubnium | |||
| # Install angular-cli | |||
| $ npm i -g angular-cli | |||
| $ npm i -g @angular/cli@8.3.25 | |||
There was a problem hiding this comment.
In documentation, I think that yes.
I follow it and fetch angular-cli 1.0.0beta32 (or similar) which was a problem to have a development environment.
blankoworld
force-pushed
the
doo-769-fix-library-name
branch
2 times, most recently
from
58b789c
to
5a539fe
Compare
blankoworld
force-pushed
the
doo-769-fix-library-name
branch
from
5a539fe
to
1b18969
Compare
Garfield-fr
reviewed
Feb 21, 2020
* Displays library name (and location name) while loan is in transit status * Fixes rero/rero-ils#769 * Completes documentation about angular-cli installation Co-Authored-by: Olivier DOSSMANN <git@dossmann.net> Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
blankoworld
force-pushed
the
doo-769-fix-library-name
branch
from
1b18969
to
f7bb446
Compare
sebdeleze
approved these changes
Feb 21, 2020
zannkukai
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Olivier DOSSMANN git@dossmann.net
Why are you opening this PR?
Because of rero/rero-ils#769
How to test?
Cf. issue 769 to check
Code review check list