circulation: fix several issues #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
from
9ed0866
to
d91a532
Compare
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
3 times, most recently
from
54043bf
to
ec8ad07
Compare
sebdeleze
reviewed
Feb 25, 2020
projects/admin/src/app/circulation/patron/card/card.component.html
Outdated
Show resolved
Hide resolved
sebdeleze
approved these changes
Feb 25, 2020
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
3 times, most recently
from
3634357
to
830fbd4
Compare
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
3 times, most recently
from
a2bfe21
to
8d5e5cc
Compare
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
from
8d5e5cc
to
9303e49
Compare
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
from
9303e49
to
820d4b0
Compare
* Adds space between patron lastname and firstname. Closes rero/rero-ils#790. * Trims barcode entererd in search input. Closes rero/rero-ils#789. * Changes message when a checkout is done on an item that is already on loan. Closes rero/rero-ils#791. * Displays action performed in checkin view. Closes rero/rero-ils#792. * Adds space between 'no loan' message an table. Closes rero/rero-ils#799. * Corrects destination display for in transit items. Closes rero/rero-ils#769. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-circulation-ui-fix
branch
from
820d4b0
to
b102977
Compare
benerken
approved these changes
Feb 26, 2020
sebdeleze
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To close issues mentioned above.
How to test?
Important (769):
Check the display of destination when an item is in transit
790:
Go to circulation view of a patron.
Check the name.
789:
Go to checkin/checkout form.
Enter a valid barcode with leading or trailing space.
791:
Try to checkout an item that is already on loan and check the flash message.
792:
Perform actions in checkin view (User services > Circulation).
Check that actions done are displayed.
799:
Checkin all items of a patron and confirm that there is space between the message and the table.
Code review check list