Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate request form: set focus in search input #196

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

AoNoOokami
Copy link
Contributor

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To close rero/rero-ils#803

How to test?

  1. In admin view, got to User services > Requests
  2. Validate a request by scanning a barcode in the list.
  3. Check that the focus is set to the search input.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Sets focus in search input after validation.
* Closes rero/rero-ils#803.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-focus-request-form branch from aeb23c3 to 28a78d4 Compare February 28, 2020 08:59
@AoNoOokami AoNoOokami self-assigned this Feb 28, 2020
@AoNoOokami AoNoOokami requested review from blankoworld, lauren-d, jma, Garfield-fr and sebdeleze and removed request for blankoworld and lauren-d February 28, 2020 09:09
@AoNoOokami AoNoOokami requested review from lauren-d and removed request for Garfield-fr March 2, 2020 10:52
@AoNoOokami AoNoOokami removed the request for review from lauren-d March 3, 2020 07:32
@AoNoOokami AoNoOokami merged commit 59c0797 into rero:dev Mar 3, 2020
@AoNoOokami AoNoOokami deleted the zaa-focus-request-form branch March 18, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants