project code: rename a component #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1336-checkin-request-to-validate
branch
from
a7dc296
to
2c2eee7
Compare
zannkukai
approved these changes
Mar 13, 2020
AoNoOokami
force-pushed
the
zaa-#1336-checkin-request-to-validate
branch
from
2c2eee7
to
26e7a47
Compare
sebdeleze
reviewed
Mar 17, 2020
projects/admin/src/app/circulation/checkin/checkin.component.spec.ts
Outdated
Show resolved
Hide resolved
sebdeleze
suggested changes
Mar 17, 2020
projects/admin/src/app/circulation/checkin/checkin.component.ts
Outdated
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-#1336-checkin-request-to-validate
branch
2 times, most recently
from
930458c
to
d81c66e
Compare
AoNoOokami
requested review from
sebdeleze and
jma
and removed request for
blankoworld
* Renames checkout component accordingly to its usage (checkins). Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1336-checkin-request-to-validate
branch
from
d81c66e
to
16709c7
Compare
jma
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
For the compliance between name and usage of this component.
How to test?
N/A
Code review check list