document: filter results by org in admin view #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
4 times, most recently
from
e0e25bc
to
91f0a3a
Compare
7 tasks
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
91f0a3a
to
5dd8139
Compare
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
5dd8139
to
e64286a
Compare
sebdeleze
suggested changes
Apr 8, 2020
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
e64286a
to
ad42c61
Compare
sebdeleze
suggested changes
Apr 15, 2020
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
2 times, most recently
from
53f3496
to
bbdada0
Compare
benerken
approved these changes
Apr 15, 2020
sebdeleze
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Some doc blocks are not well formatted (https://github.com/rero/rero-ils-ui/pull/208/files#diff-bf02d3d46f102054384e43e8deae3686R120, one empty line after description and @param and @return must be grouped), but it doesn't matter.
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
bbdada0
to
343fee7
Compare
Ok, corrected. There was a typo in the commit message anyway. |
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
343fee7
to
315c20d
Compare
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
315c20d
to
c4d58fe
Compare
|
Needs ng-core publication to pass the CI: rero/ng-core#174 |
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
c4d58fe
to
bba0d56
Compare
7 tasks
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
bba0d56
to
38f2f4c
Compare
* Fixes display of organisation facet in document brief view. * Modifies links to documents brief view to include current organisation as a default parameter. * Closes rero#140. * Removes useless code. * Implements results and suggestions filtering for search in main bar. * Updates @rero/ng-core version for the latest one. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1377-filter-results-by-org
branch
from
38f2f4c
to
e6ffd7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1377?kanban-status=1224895
How to test?
Needs rero/rero-ils#852 and last version of ng-core.
Public search
organisationfacet in global viewlibraryfacet in organisation views.Admin
organisation+libraries)Code review check list