Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: fix uniqueness check value for locations #210

Merged
merged 1 commit into from
Mar 21, 2020
Merged

editor: fix uniqueness check value for locations #210

merged 1 commit into from
Mar 21, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Mar 19, 2020 •
edited
Loading

Several fields needs to be unique by library, such as is_online, pickup name, etc. , when a location is created
or updated. This check did not work since a refactoring.

Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Unique validation for is_online and pickup name for locations.

How to test?

  • Create or edit a new location for a library with existing online or pickup location. An error should appears when we try to create a second online location or a location with an existing pickup name.

Note

  • a validation should be done in the backend to detect frontend validation failure.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma
editor: fix uniqueness check value for locations
ee959dd 
Several fields needs to be unique by library, such as is_online, pickup name, etc. , when a location is created
or updated. This check did not work since a refactoring.

Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma requested review from AoNoOokami and zannkukai March 19, 2020 10:28
@jma jma merged commit d4f1828 into rero:dev Mar 21, 2020
@jma jma deleted the maj-fix-unique-value-location branch July 14, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @zannkukai @AoNoOokami