Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locations: hide action buttons depending of parent permissions #223

Merged
merged 1 commit into from
Apr 6, 2020
Merged

locations: hide action buttons depending of parent permissions #223

merged 1 commit into from
Apr 6, 2020

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Apr 2, 2020 •
edited
Loading

When you display a library detail, locations action buttons are displayed even if
current logged user doesn't have permissions to update the library.
This PR fixes this problem.

Ca-authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • Login as Jean (Librarian)
  • Display the detail of library 1 : ~/records/libraries/detail/1
  • No actions should be available for any locations
  • Display the detail of Jean's library : ~/records/libraries/detail/2
  • You should view the "add", "delete" and "edit" action buttons for locations

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai
locations: hide action buttons depending of parent permissions
fd54935 
When you display a library detail, locations action buttons are displayed even if
current logged user doesn't have permissions to update the library.
This PR fixes this problem.

Ca-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai added the WIP label Apr 2, 2020
@zannkukai zannkukai self-assigned this Apr 2, 2020
@zannkukai zannkukai marked this pull request as ready for review April 2, 2020 17:33
@zannkukai zannkukai requested a review from AoNoOokami April 2, 2020 17:40
@zannkukai zannkukai removed the WIP label Apr 2, 2020
@zannkukai zannkukai requested review from jma and lauren-d April 3, 2020 16:13
@zannkukai zannkukai merged commit cc834c3 into rero:dev Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zannkukai @jma @AoNoOokami