Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search view: hide the add button for public views #243

Merged
merged 1 commit into from
Apr 9, 2020
Merged

search view: hide the add button for public views #243

merged 1 commit into from
Apr 9, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Apr 9, 2020 •
edited
Loading

  • Adapts the configuration for the search views that disables administrative functionalities to be compatible with the new ng-core version. This removes all professional buttons from these search views.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • To fix admin button on the public, organisation and person search views.

How to test?

  • Run the public view server and go to the public search views. The add button should not be present.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-fix-admin-mode branch 2 times, most recently from 35c1b96 to c60e4c2 Compare April 9, 2020 13:00
@jma
search view: hide the add button for public views
0ccbb2b 
* Adapts the configuration for the search views that disables administrative functionalities to be compatible with the new ng-core version. This removes all professional buttons from these search views.
* Adds missing licence in the header source files.
* Fixes console error message when the item detailed view is displayed.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma marked this pull request as ready for review April 9, 2020 13:09
@jma jma merged commit 8a3b485 into rero:dev Apr 9, 2020
@jma jma deleted the maj-fix-admin-mode branch April 9, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankoworld blankoworld blankoworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma @blankoworld